Gotcha - Improper exception handling

Viagra.

Viagra. — Sun, 29 Mar 2009 11:54:00 GMT

Viagra. Generic viagra mastercard. Order viagra online. Buy cheap viagra online uk. Free viagra.

re: Gotcha - Improper exception handling

AJ.NET — Tue, 04 Dec 2007 14:05:32 GMT

FYI: System.Exception has a property "Data" (type IDictionary) (new in .NET 2.0). Thus it is no longer necessary to provide a derived exception class "only" to add some piece of information. For me the reasons to wrap an exception are usually a) to provide a better suited exception class to _describe_ the error or b) to provide better destinction of errors for code that _handles_ the error (i.e. catch-handlers). Providing the inner exception is of course mandatory...

No soup for me » Blog Archive » Makes me wanna throw ex;

No soup for me » Blog Archive » Makes me wanna throw ex; — Fri, 30 Nov 2007 23:17:17 GMT

Pingback from No soup for me » Blog Archive » Makes me wanna throw ex;

re: Gotcha - Improper exception handling

Nikola Malovic — Fri, 30 Nov 2007 20:55:24 GMT

Justin,

I agree 100% that raising the Exception type of exception is totally wrong practice but IMHO using of ApplicationException is equally bad and I am sure I read it on couple of places not recomended any more from MS.

What we should use is either some specific exception which match the exception case scenario such are InvalidOperationException, ArgumentException etc or our own custom exceptions.

I am really glad that FXCop reports an issue with usage of Exception, which is very useful in answering the "why not just use Exception" :)

mcgurk,

I agree it is funny and small thing but I spent an descent amount of time hunting bugs in cases where the stack was destroyed or in even worse swallowing catch {} case (which btw makes me bloodthirsty :) )

re: Gotcha - Improper exception handling

mcgurk — Fri, 30 Nov 2007 18:47:14 GMT

I always laugh when I see people discussing best practices and then do something like throw a System.Exception object. However, I agree with you. If you must catch and throw, wrap a base exception in another exception type and throw that. Primarily because people up the call chain won't have to attempt to catch twenty thousand different types of exceptions.

re: Gotcha - Improper exception handling

Justin Etheredge — Fri, 30 Nov 2007 18:41:19 GMT

I think that "throw;" is your best option if you don't have any additional data to add to your exception. If you do have data, then passing the old exception as an inner exception is the best way to go. They are both "best practices" for their respective situations. Which is why I hate the term "best practice", it makes it sound way too much like a universal solution. But I digress. Also, you should point out that raising the type "Exception" is not best practice and it should always be subclassed, and preferably from the ApplicationException class if you are really being anal about it. :-)

re: Gotcha - Improper exception handling

Javier Romero — Fri, 30 Nov 2007 16:48:10 GMT

Nice explanation, there are many devs that don't know the real and useful information of the stack...

Why throw; is not allways the best way to rethrow exceptions

DotNetKicks.com — Fri, 30 Nov 2007 12:39:36 GMT

You've been kicked (a good thing) - Trackback from DotNetKicks.com